Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module2 #11

Open
wants to merge 227 commits into
base: main
Choose a base branch
from
Open

Module2 #11

wants to merge 227 commits into from

Conversation

ptesavol
Copy link
Collaborator

@ptesavol ptesavol commented Aug 8, 2024 •
edited
Loading

Add streamr-proto-rpc package

This is the c++ equvivalent of the typescript proto-rpc package of streamr-network.

Differences compared to the typescript version

  • outgoingMessageListener renamed to outgoingMessageCallback
  • removed redundant emitting of outgoing messages as events
  • generates its own client and server classes with its own plugin directly using google protoc
  • split RpcCommunicator to 3 parts to increase code readability

ptesavol and others added 30 commits May 31, 2024 11:47
@ptesavol
create directory structure
136b30b
@ptesavol
working empty monorepo
13fc96a
@ptesavol
add build instructions to readme
6b1bd4a
@ptesavol
also clean the main build folder
51e9d51
@ptesavol
add CONFIG flag to folly find_package
857e373
@ptesavol
it builds
34b89a6
@ptesavol
rename build.sh to install.sh so build.sh can be the name for the nor…
628d430 
…mal build scripts
@ptesavol
add testing scripts
d2d6c55
@ptesavol
lint works in sub-projects
ae8fdb4
@ptesavol
update README
3dee7c3
@ptesavol
Merge branch 'wp1' of github.com:streamr-dev/native-sdk into wp1
06a79c0
@ptesavol
updated tooling
f0572b6
@ptesavol
updated prerequisities script
051cd33
@SanttuRantanen
StreamrFormatter is ready for implementation
13da152
@SanttuRantanen
Output of StreamrFormatter is now in format like this: INFO [2024-06-…
149e42e 
…06T14:29:36] (Logger.hpp): dddkdkdkkdkdkdkdkdkd
@ptesavol
enable linting
451a5d9
@SanttuRantanen
Fixed size filename and linenumber added (Including filename truncate…
ec86faf 
…). Colors added to LogLevels)
@ptesavol
remove automatic pre-commit formatting
fef18f3
@ptesavol
add pre-commit checking
d47619d
@SanttuRantanen
logDebug level fixed
d1dc6c3
@ptesavol
get runk to work with clangd-tidy
b197766
@ptesavol
improve testing setup
cf83b7e
@SanttuRantanen
formatMessageInStreamrStyle added. It is easier to unit test with it
9722c1a
@SanttuRantanen
StreamrFormatterTest template added
ec6fdfd
@ptesavol
added ci workflows
ef03d41
@SanttuRantanen
Correct colors included
3fb4ada
@SanttuRantanen
Message color added
4162eb0
@SanttuRantanen
StreamrLogFormatterTest tests added
257e54e
@SanttuRantanen
SLOG_TRACE, SLOG_DEBUG... macros added. They work with lazy init so t…
7c2b25c 
…hat the Logger class is not needed to create explicitly
@SanttuRantanen
Little bit cleaning
a71e922
juslesan
juslesan reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@juslesan juslesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on RpcCommunicator and ServerRegistry

packages/streamr-proto-rpc/include/streamr-proto-rpc/RpcCommunicator.hpp Outdated Show resolved Hide resolved
packages/streamr-proto-rpc/include/streamr-proto-rpc/RpcCommunicator.hpp Outdated Show resolved Hide resolved
packages/streamr-proto-rpc/include/streamr-proto-rpc/RpcCommunicator.hpp Outdated Show resolved Hide resolved
packages/streamr-proto-rpc/include/streamr-proto-rpc/RpcCommunicator.hpp Outdated Show resolved Hide resolved
packages/streamr-proto-rpc/protos/ProtoRpc.proto Show resolved Hide resolved
packages/streamr-proto-rpc/include/streamr-proto-rpc/ServerRegistry.hpp Outdated Show resolved Hide resolved
packages/streamr-proto-rpc/include/streamr-proto-rpc/RpcCommunicator.hpp Outdated Show resolved Hide resolved
packages/streamr-proto-rpc/include/streamr-proto-rpc/RpcCommunicator.hpp Outdated Show resolved Hide resolved
@ptesavol
Copy link
Collaborator Author

If using this component as a javascript native module, it would depend on the interface of the module if we would need to generate the protobuf classes also for typescript.

@github-actions github-actions bot added ci Pull requests that update Continuous Integration build proto-rpc utils logger labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juslesan juslesan juslesan left review comments

@harbu harbu Awaiting requested review from harbu

@jtakalai jtakalai Awaiting requested review from jtakalai

Assignees
No one assigned
Labels
ci Pull requests that update Continuous Integration build logger proto-rpc utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ptesavol @juslesan @SanttuRantanen @jtakalai